Learner1D type hints and add typeguard to pytest tests#325
Merged
basnijholt merged 5 commits intomasterfrom Aug 30, 2021
Merged
Learner1D type hints and add typeguard to pytest tests#325basnijholt merged 5 commits intomasterfrom
basnijholt merged 5 commits intomasterfrom
Conversation
basnijholt
force-pushed
the
learner1d-type-hints
branch
2 times, most recently
from
1d2496f to
3d359c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 80.72% 80.77% +0.04%
==========================================
Files 38 38
Lines 5018 5045 +27
Branches 918 918
==========================================
+ Hits 4051 4075 +24
- Misses 822 824 +2
- Partials 145 146 +1
Continue to review full report at Codecov.
|
basnijholt
force-pushed
the
learner1d-type-hints
branch
from
3d359c3 to
71d1d6f
Compare
basnijholt
force-pushed
the
learner1d-type-hints
branch
from
799ab5e to
b10e18d
Compare
basnijholt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am splitting up #244 into smaller parts.
Since it has been ready for review for almost 2 years but no-one has looked at it, I will go ahead and auto-complete this as soon as the
typeguardandmypyissues have been solved.Checklist
pre-commit run --all(first install usingpip install pre-commit)pytestpassedType of change
Check relevant option(s).